[Infra] Wait for NuGet packages to be published during release process#7163
Draft
martincostello wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
Conversation
Add a workflow that waits for all the NuGet packages associated with a release to be published to NuGet.org and then posts a comment on the release PR once they are.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7163 +/- ##
==========================================
+ Coverage 89.08% 89.11% +0.03%
==========================================
Files 271 271
Lines 13073 13073
==========================================
+ Hits 11646 11650 +4
+ Misses 1427 1423 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is more of an RFC for now before I'd refactor more of the release process to leverage this fully.
In 2024 I wrote a .NET global tool that waits until one or more NuGet package has been fully published to NuGet.org for release automation. The UX is something like this.
I thought it would be a good idea to use it here to smooth out the release process.
At the moment, the PR to update the versions (e.g. #7125) is opened ~immediately after the release is published from a PR comment (e.g. #7123).
This PR then fails, and needs to be manually re-run once all the relevant packages are indexed and downloadable from NuGet.org.
Instead, if we waited for the NuGet packages to be available and then opened the PR, we'd waste CI resource on doomed-to-fail builds.
For now to illustrate the idea, this PR adds a workflow that waits for all the NuGet packages associated with a release to be published to NuGet.org and then posts a comment on the release PR once they are.
If people are happy, I can do further refactoring to change the workflow to:
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)