[Shims.OpenTracing] Fixes support for byte, short, int, float attributes by Kielek · Pull Request #7080 · open-telemetry/opentelemetry-dotnet

Kielek · 2026-04-15T07:37:43Z

Fixes Codex/security findings. It is not considered as a security fix. Just detected during such scans.

Changes

[Shims.OpenTracing] Fixes support for byte, short, int, float attributes
Technically, package is deprecated, but the fix seems be easy enough to avoid occurrence in the similar scans in the future.

Merge requirement checklist

CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
Unit tests added/updated
Appropriate CHANGELOG.md files updated for non-trivial changes
~~[ ] Changes in public API reviewed (if applicable)~~

codecov · 2026-04-15T07:42:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.72%. Comparing base (a1b6e6a) to head (cdb12f3).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7080      +/-   ##
==========================================
- Coverage   88.74%   88.72%   -0.02%     
==========================================
  Files         270      270              
  Lines       12919    12927       +8     
==========================================
+ Hits        11465    11470       +5     
- Misses       1454     1457       +3

Flag	Coverage Δ
unittests-Project-Experimental	`88.69% <100.00%> (+0.24%)`	⬆️
unittests-Project-Stable	`88.68% <100.00%> (-0.05%)`	⬇️
unittests-UnstableCoreLibraries-Experimental	`41.31% <100.00%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs	`85.43% <100.00%> (+5.43%)`	⬆️

... and 4 files with indirect coverage changes

….3 (#1015) Updated [OpenTelemetry.Exporter.OpenTelemetryProtocol](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.15.2 to 1.15.3. <details> <summary>Release notes</summary> _Sourced from [OpenTelemetry.Exporter.OpenTelemetryProtocol's releases](https://github.com/open-telemetry/opentelemetry-dotnet/releases)._ ## 1.15.3 For highlights and announcements pertaining to this release see: [Release Notes > 1.15.3](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/RELEASENOTES.md#1153). The following changes are from the previous release [1.15.2](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.15.2). * NuGet: [OpenTelemetry v1.15.3](https://www.nuget.org/packages/OpenTelemetry/1.15.3) * Fix resource leak in batch and periodic exporting task workers for Blazor/WASM. ([#7069](open-telemetry/opentelemetry-dotnet#7069)) * Fixed `LogRecord.LogLevel` to preserve `LogLevel.None` and handle unspecified or out-of-range severities without returning invalid enum values. ([#7092](open-telemetry/opentelemetry-dotnet#7092)) * Fixed `OTEL_TRACES_SAMPLER_ARG` handling to treat out-of-range, `NaN`, and infinite values as invalid and fall back to the default ratio when using `traceidratio` and `parentbased_traceidratio` samplers. ([#7103](open-telemetry/opentelemetry-dotnet#7103)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.15.3/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.15.3](https://www.nuget.org/packages/OpenTelemetry.Api/1.15.3) * Fix baggage and trace headers not respecting the maximum length in some cases. ([#7061](open-telemetry/opentelemetry-dotnet#7061)) * Improve efficiency of parsing of baggage and B3 propagation headers. ([#7061](open-telemetry/opentelemetry-dotnet#7061)) * **Breaking change:** Fixed `tracestate` parsing to reject keys that do not begin with a lowercase letter, including keys beginning with digits, to align with the W3C Trace Context specification. ([#7065](open-telemetry/opentelemetry-dotnet#7065)) * Fixed `BaggagePropagator` to trim optional whitespace (OWS) around `=` separators when parsing the `baggage` header, as required by the [W3C Baggage specification](https://www.w3.org/TR/baggage/). ([#7009](open-telemetry/opentelemetry-dotnet#7009)) * Fixed `BaggagePropagator` to strip baggage properties (e.g. `;metadata`) from values when parsing the `baggage` header. ([#7009](open-telemetry/opentelemetry-dotnet#7009)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.15.3/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.15.3](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.15.3) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.15.3/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. ... (truncated) ## 1.15.3-beta.1 The following changes are from the previous release [1.15.2-beta.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/coreunstable-1.15.2-beta.1). * NuGet: [OpenTelemetry.Exporter.Prometheus.AspNetCore v1.15.3-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.AspNetCore/1.15.3-beta.1) * Fixed metric unit strings containing invalid Prometheus characters (e.g. `# RU`) not being sanitized, resulting in malformed metric names. ([#6187](open-telemetry/opentelemetry-dotnet#6187)) * Fixed Prometheus metric serialization to handle empty label names without throwing during scrape rendering. ([#7077](open-telemetry/opentelemetry-dotnet#7077)) * Updated OpenTelemetry core component version(s) to `1.15.3`. ([#7125](open-telemetry/opentelemetry-dotnet#7125)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.15.3-beta.1/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Prometheus.HttpListener v1.15.3-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.HttpListener/1.15.3-beta.1) * Fixed metric unit strings containing invalid Prometheus characters (e.g. `# RU`) not being sanitized, resulting in malformed metric names. ([#6187](open-telemetry/opentelemetry-dotnet#6187)) * Fixed Prometheus metric serialization to handle empty label names without throwing during scrape rendering. ([#7077](open-telemetry/opentelemetry-dotnet#7077)) * Updated OpenTelemetry core component version(s) to `1.15.3`. ([#7125](open-telemetry/opentelemetry-dotnet#7125)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.15.3-beta.1/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Shims.OpenTracing v1.15.3-beta.1](https://www.nuget.org/packages/OpenTelemetry.Shims.OpenTracing/1.15.3-beta.1) * Fixes support for `byte`, `short`, `int`, and `float` attributes. ([#7080](open-telemetry/opentelemetry-dotnet#7080)) * Updated OpenTelemetry core component version(s) to `1.15.3`. ([#7125](open-telemetry/opentelemetry-dotnet#7125)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.15.3-beta.1/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md) for details. Commits viewable in [compare view](open-telemetry/opentelemetry-dotnet@core-1.15.2...core-1.15.3). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=OpenTelemetry.Exporter.OpenTelemetryProtocol&package-manager=nuget&previous-version=1.15.2&new-version=1.15.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[Shims.OpenTracing] Fixes support for byte, short, int, float attributes

f5987be

github-actions Bot added the pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package label Apr 15, 2026

changelog

f363e9c

Kielek marked this pull request as ready for review April 15, 2026 07:38

Kielek requested a review from a team as a code owner April 15, 2026 07:38

martincostello reviewed Apr 15, 2026

View reviewed changes

Comment thread test/OpenTelemetry.Shims.OpenTracing.Tests/SpanShimTests.cs

Kielek added 2 commits April 15, 2026 11:19

fraction tests

18a1031

lint fix

cdb12f3

martincostello approved these changes Apr 15, 2026

View reviewed changes

Comment thread test/OpenTelemetry.Shims.OpenTracing.Tests/SpanShimTests.cs Outdated

Kielek added this pull request to the merge queue Apr 15, 2026

Merged via the queue into open-telemetry:main with commit 53d590c Apr 15, 2026
63 checks passed

Kielek deleted the opentracing-tags branch April 15, 2026 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Shims.OpenTracing] Fixes support for byte, short, int, float attributes#7080

[Shims.OpenTracing] Fixes support for byte, short, int, float attributes#7080
Kielek merged 4 commits intoopen-telemetry:mainfrom
Kielek:opentracing-tags

Kielek commented Apr 15, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Kielek commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Merge requirement checklist

Uh oh!

codecov Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kielek commented Apr 15, 2026 •

edited

Loading

codecov Bot commented Apr 15, 2026 •

edited

Loading