[DNM] Performance improvements#7062
Closed
martincostello wants to merge 25 commits intoopen-telemetry:mainfrom
Closed
[DNM] Performance improvements#7062martincostello wants to merge 25 commits intoopen-telemetry:mainfrom
martincostello wants to merge 25 commits intoopen-telemetry:mainfrom
Conversation
Add support for GZip compression to the OTLP exporter. Picks up from open-telemetry#6494. Resolves open-telemetry#3961. Co-Authored-By: Hannah Haering <157852144+hannahhaering@users.noreply.github.com>
Pool `SuppressInstrumentationScope` instances to avoid allocations.
Add `[MemoryDiagnoser]` to `SuppressInstrumentationScope` benchmarks.
Remove emdash.
Optimize `SamplingResult` for cases when there are no attributes to avoid allocating an enumerator and add benchmarks.
- Avoid allocating a buffer for every write of compressed gRPC data. - Simplify `IsTransientNetworkError()`.
Add coverage for different ways to specify the compression value.
Use normal dashes.
The benchmark doesn't call the method directly, so it can stay private.
Remove inaccurate comment.
- Reduce the size of the pool. - Avoid over-eager stack allocation. - Use a singleton `NoOpDisposable`.
- Prevent disposing stale references. - Add more tests.
Remove emdash.
- Ensure only one `grpc-encoding` header. - Remove redundant null checks.
Add benchmarks for `BaggagePropagator`.
- Avoid LINQ. - Use spans where possible.
Refactor based on suggestions from Copilot to improve throughput and reduce allocations by avoiding LINQ.
Extend test coverage for `TraceContextPropagator`.
Address Copilot code review feedback.
Add test that appears to relate to GHSA-8785-wc3w-h8q6, although it passes before and after that change was reverted.
Fix-up the regression test so it actually detects the issue caused by open-telemetry#5749.
…ormance-improvements
github-actions
Bot
added
pkg:OpenTelemetry.Api
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7062 +/- ##
==========================================
+ Coverage 88.39% 88.49% +0.09%
==========================================
Files 270 270
Lines 12758 12993 +235
==========================================
+ Hits 11278 11498 +220
- Misses 1480 1495 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Initial net summary of comparing the changes from this PR from a Grafana k6 run for martincostello/costellobot@4e92338 vs. martincostello/costellobot@a9c505c. Differences:
CPUBefore
After
AllocationsBefore
After
|
4 tasks
Member
Author
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Combines the changes from the following PRs so I can get a single set of NuGet packages from CI to test:
Not intended for review or to be merged.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)