Align Baggage API name and value handling to match the v1.36.0 specification#6931
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6931 +/- ##
==========================================
+ Coverage 88.49% 88.51% +0.01%
==========================================
Files 263 263
Lines 12408 12411 +3
==========================================
+ Hits 10980 10985 +5
+ Misses 1428 1426 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Please check also https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/22649769411/job/65646261419?pr=6931 |
…n testing that baggage names and values can accept any valid UTF-8 string. This tests both Unicode characters in Basic Multilingual Plane (U+0000 to U+FFFF) and in supplementary code points (U+10000 to U+10FFFF)
… an empty string.
… and link to the specification.
|
I checked also v1.54.0 version - only redactional changes related to the scope of PR. open-telemetry/opentelemetry-specification@v1.36.0...v1.54.0#diff-3d2a0e870c26fa9f2827cc33bd44f1b56939c65a35f55d5d988ebfd6a8d08c82 |
|
Thank you for your contribution @zacharycmontoya! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Partially addresses #5210
Design discussion issue: N/A
Changes
This PR updates the
OpenTelemetry.Baggagetype so that it handles baggage name and values in accordance with the v1.36.0 specification:No changes were required to handle UTF-8 strings, but new tests were added to assert this behavior.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes