-
Notifications
You must be signed in to change notification settings - Fork 868
Decode value in OTEL_RESOURCE_ATTRIBUTES environment variable
#6737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode value in OTEL_RESOURCE_ATTRIBUTES environment variable
#6737
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6737 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 259 259
Lines 12066 12068 +2
=======================================
+ Hits 10483 10485 +2
Misses 1583 1583
Flags with carried forward coverage won't be shown. Click here to find out more.
|
value in OTEL_RESOURCE_ATTRIBUTES environment variable
|
how is this different from #6461 |
The biggest difference is that this is not in the hot path. This PR is simply a bug fix for The functionality is covered in that PR if that goes through. However, that one is in the hot path (baggage propagation) and needs lots of scrutiny. That one also validates key and value doesn't contain invalid characters. |
test/OpenTelemetry.Tests/Resources/OtelEnvResourceDetectorTests.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #3395.
OTEL_RESOURCE_ATTRIBUTESenvironment variable should follow format of W3C Baggage: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md#specifying-resource-information-via-an-environment-variableW3C Baggage value definition: https://www.w3.org/TR/baggage/#value
Changes
Please provide a brief description of the changes here.
valueinOTEL_RESOURCE_ATTRIBUTES.=) as key-value separator. The rest are part ofvalue.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)