Skip to content

Conversation

@xiang17
Copy link
Contributor

@xiang17 xiang17 commented Oct 25, 2024

Fixes #5444.

Changes

Promote cardinality limit view API from experimental to stable. Updates README and obsolete flags for MeterProviderBuilder.SetMaxMetricPointsPerMetricStream to note that they are in stable.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable): The APIs were in src\OpenTelemetry\.publicApi\Experimental\PublicAPI.Unshipped.txt.

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters documentation Documentation related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Oct 25, 2024
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.02%. Comparing base (6250307) to head (53ed5af).
Report is 361 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5926      +/-   ##
==========================================
+ Coverage   83.38%   86.02%   +2.64%     
==========================================
  Files         297      260      -37     
  Lines       12531    11437    -1094     
==========================================
- Hits        10449     9839     -610     
+ Misses       2082     1598     -484     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 85.95% <ø> (?)
unittests-Project-Stable 86.00% <ø> (?)
unittests-Solution 85.95% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 84.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../Metrics/Builder/MeterProviderBuilderExtensions.cs 98.42% <ø> (-1.58%) ⬇️
...elemetry/Metrics/View/MetricStreamConfiguration.cs 88.88% <ø> (ø)

... and 237 files with indirect coverage changes

@xiang17 xiang17 marked this pull request as ready for review October 25, 2024 22:48
@xiang17 xiang17 requested a review from a team as a code owner October 25, 2024 22:48

Released stable: `1.9.0`

### OTEL1003
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be moved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was simply following the convention of the OTEL1002 above which was released and moved from "Active" to "Inactive". Personally I think it'd also be helpful to have a record of what happened to previous experimental features.

## Unreleased

* The experimental APIs previously covered by `OTEL1003`
(`MetricStreamConfiguration.CardinalityLimit`) will now be part of the public
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be -> is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording is also used in other experimental APIs in this CHANGELOG.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "is" is better. Would be good to follow up and make changes everywhere. Not a blocker for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a PR #5940 for this.

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple suggestions/questions that are non-blocking.

This was referenced Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related infra Infra work - CI/CD, code coverage, linters metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promote cardinality limit view API from experimental to stable

5 participants