Skip to content

Conversation

@rajkumar-rangaraj
Copy link
Member

@rajkumar-rangaraj rajkumar-rangaraj commented Jul 9, 2024

Discussion for this issue can be found at dotnet/runtime#104619

  • The test and example project references for System.Text.Json have been updated.
  • The Console and Zipkin exporters use a safe version (4.7.2) of System.Text.Json, so no update is needed there.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team July 9, 2024 23:35
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file documentation Documentation related pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package labels Jul 9, 2024
@codecov
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (6250307) to head (f203db7).
Report is 278 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5744      +/-   ##
==========================================
+ Coverage   83.38%   86.19%   +2.81%     
==========================================
  Files         297      254      -43     
  Lines       12531    11057    -1474     
==========================================
- Hits        10449     9531     -918     
+ Misses       2082     1526     -556     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.12% <ø> (?)
unittests-Project-Stable 86.19% <ø> (?)
unittests-Solution 86.17% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 85.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 197 files with indirect coverage changes

@cremor
Copy link

cremor commented Jul 10, 2024

FYI: dotnet/runtime#104619 (comment)
Meaning: Maybe the version you are currently using isn't even vulnerable.

@rajkumar-rangaraj
Copy link
Member Author

FYI: dotnet/runtime#104619 (comment) Meaning: Maybe the version you are currently using isn't even vulnerable.

Thanks @cremor 4.7.2 version is not vulnerable. I will change this PR to update the test and examples package.

@github-actions github-actions bot removed pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package labels Jul 10, 2024
@rajkumar-rangaraj
Copy link
Member Author

CI is reporting the below errors, but 4.7.2 is not vulnerable.

image

@cijothomas cijothomas closed this Jul 11, 2024
@cijothomas cijothomas reopened this Jul 11, 2024
@cijothomas
Copy link
Member

@alanwest Could you help merge this? Blanch is on vacation, and this is pre-req to unblock any other PRs.

@cijothomas
Copy link
Member

@alanwest Could you help merge this? Blanch is on vacation, and this is pre-req to unblock any other PRs.

Looks like Alan is also on vacation, so need someone from TC to merge. @reyang can you help?

@alanwest
Copy link
Member

I am out today, but could be available to merge this. Will be near a computer soonish. I see build failed though...

@cijothomas
Copy link
Member

I am out today, but could be available to merge this. Will be near a computer soonish. I see build failed though...

Prior failure was due to nuget/ci bug that incorrectly detected 4.7.2 as vulnerable. I re-triggerred CI, hopefully it should pass!

@cijothomas
Copy link
Member

CI is green now :)

@alanwest alanwest merged commit dbe2ce3 into open-telemetry:main Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Documentation related infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants