Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Bump Microsoft.SourceLink.GitHub to 8.0.0 #5728

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 28, 2024

Fixes N/A
Design discussion issue N/A

Changes

Bump Microsoft.SourceLink.GitHub to 8.0.0

I am playing locally with OTel Exporter package directly included into AutoInstrumentation project and I have some conficts.
There should be no problem with this upgrade as it is fully internal package. Contrib already references this version.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file labels Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (6250307) to head (9dc1810).
Report is 274 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5728      +/-   ##
==========================================
+ Coverage   83.38%   86.19%   +2.81%     
==========================================
  Files         297      254      -43     
  Lines       12531    11057    -1474     
==========================================
- Hits        10449     9531     -918     
+ Misses       2082     1526     -556     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.11% <ø> (?)
unittests-Project-Stable 86.12% <ø> (?)
unittests-Solution 86.14% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 85.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 197 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review June 28, 2024 10:58
@Kielek Kielek requested a review from a team as a code owner June 28, 2024 10:58
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title Bump Microsoft.SourceLink.GitHub to 8.0.0 [repo] Bump Microsoft.SourceLink.GitHub to 8.0.0 Jun 28, 2024
@CodeBlanch CodeBlanch merged commit d8ce51b into open-telemetry:main Jun 28, 2024
52 checks passed
@CodeBlanch
Copy link
Member

@Kielek

I was just poking around the repo a bit to see if there were any significant changes. Noticed this:

Using Source Link in .NET projects

Starting with .NET 8, Source Link for the following source control providers is included in the .NET SDK and enabled by default:

If your project uses .NET SDK 8+ and is hosted by the above providers it does not need to reference any Source Link packages or set any build properties.

Link: https://github.com/dotnet/sourcelink/blob/main/README.md#using-source-link-in-net-projects

Looks like we might be able to just remove this package/ref? I figured fine to merge the bump and then we can look at that separately.

@Kielek Kielek deleted the bump-Microsoft.SourceLink.GitHub branch June 28, 2024 18:50
@Kielek
Copy link
Contributor Author

Kielek commented Jun 28, 2024

@CodeBlanch, what's about packages targeted also to .NET Framework? Will it be working without this reference? I have seen this message, but do not found information about this compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants