Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.OTLP - Tests] Nullable #5720

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 25, 2024

Follow up to #5708

Changes

[Exporter.OTLP - Tests] Nullable

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (6250307) to head (61a7465).
Report is 271 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5720      +/-   ##
==========================================
+ Coverage   83.38%   86.18%   +2.79%     
==========================================
  Files         297      254      -43     
  Lines       12531    11057    -1474     
==========================================
- Hits        10449     9529     -920     
+ Misses       2082     1528     -554     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.17% <100.00%> (?)
unittests-Project-Stable 86.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 99.08% <100.00%> (+2.71%) ⬆️

... and 197 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review June 25, 2024 14:50
@Kielek Kielek requested a review from a team as a code owner June 25, 2024 14:50
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 4d254eb into open-telemetry:main Jun 25, 2024
39 checks passed
@Kielek Kielek deleted the otlp-tests-nullable branch June 25, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants