Skip to content

Conversation

@CodeBlanch
Copy link
Member

[It looks like #5246 introduced an issue into the docfx build which was able to sneak by CI.]

Changes

  • Run docfx build as part of CI if markdown files are being modified.
  • Include Directory.Packages.prop as content for docfx.
  • Include docs\logs\README.md in the solution.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team January 25, 2024 18:45
"files": [
".editorconfig",
"**.cs",
"Directory.Packages.props",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6250307) 83.38% compared to head (f18cec0) 83.12%.
Report is 29 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5257      +/-   ##
==========================================
- Coverage   83.38%   83.12%   -0.27%     
==========================================
  Files         297      271      -26     
  Lines       12531    11970     -561     
==========================================
- Hits        10449     9950     -499     
+ Misses       2082     2020      -62     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 25.07% <83.33%> (?)
unittests-Instrumentation-Stable 25.07% <83.33%> (?)
unittests-Solution-Experimental 83.10% <100.00%> (?)
unittests-Solution-Stable 83.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 89.72% <100.00%> (+0.14%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.47% <ø> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 80.77% <100.00%> (ø)
...emetry/Metrics/Exemplar/SimpleExemplarReservoir.cs 80.43% <100.00%> (ø)

... and 33 files with indirect coverage changes

@reyang reyang added the infra Infra work - CI/CD, code coverage, linters label Jan 25, 2024
@CodeBlanch CodeBlanch merged commit 914ebf9 into open-telemetry:main Jan 25, 2024
@CodeBlanch CodeBlanch deleted the repo-fix-docfx-build branch January 25, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants