Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpWebRequest] Add additional error types #5111

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Dec 1, 2023

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #5111 (d482a9b) into main (c48c014) will decrease coverage by 0.08%.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5111      +/-   ##
==========================================
- Coverage   83.11%   83.04%   -0.08%     
==========================================
  Files         296      296              
  Lines       12314    12322       +8     
==========================================
- Hits        10235    10233       -2     
- Misses       2079     2089      +10     
Flag Coverage Δ
unittests 83.04% <12.50%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...plementation/HttpWebRequestActivitySource.netfx.cs 80.81% <12.50%> (-1.35%) ⬇️

... and 4 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review December 1, 2023 23:07
@vishweshbankwar vishweshbankwar requested a review from a team December 1, 2023 23:07
@utpilla utpilla merged commit c5f5dd7 into open-telemetry:main Dec 1, 2023
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants