Skip to content

Conversation

@utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 2, 2023

Changes

  • Add isSampled check for Histogram updates so that we call ExemplarReservoir only when the ExemplarFilter samples the measurement
  • Update Benchmark.NET package version

Merge requirement checklist

  • Appropriate CHANGELOG.md files updated for non-trivial changes

@utpilla utpilla requested a review from a team November 2, 2023 05:00
@utpilla utpilla requested a review from cijothomas November 2, 2023 05:05
@codecov
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #5016 (ac4915e) into main (9ba8887) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5016      +/-   ##
==========================================
- Coverage   83.41%   83.39%   -0.02%     
==========================================
  Files         296      296              
  Lines       12377    12377              
==========================================
- Hits        10324    10322       -2     
- Misses       2053     2055       +2     
Flag Coverage Δ
unittests 83.39% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/MetricPoint.cs 68.27% <33.33%> (-0.20%) ⬇️

... and 5 files with indirect coverage changes

| HistogramWithTagReduction | AlwaysOff | 298.9 ns | 2.44 ns | 2.16 ns |
| HistogramNoTagReduction | AlwaysOn | 359.6 ns | 1.26 ns | 1.11 ns |
| HistogramWithTagReduction | AlwaysOn | 400.1 ns | 4.16 ns | 3.90 ns |
| HistogramNoTagReduction | HighValueOnly | 325.3 ns | 3.33 ns | 2.78 ns |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 ! Thanks for fixing this! I was discussing last week why the perf was not improving a lot despite the Filter!

@utpilla utpilla merged commit ba161c4 into open-telemetry:main Nov 2, 2023
@utpilla utpilla deleted the utpilla/Update-Exemplars-for-Histograms branch November 3, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants