[api] Fix Tracer.StartRootSpan so that it always creates a root span #4890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
added
the
pkg:OpenTelemetry.Api
|
Related to dotnet/runtime#65528. |
Codecov Report
@@ Coverage Diff @@
## main #4890 +/- ##
==========================================
- Coverage 82.94% 82.93% -0.01%
==========================================
Files 294 294
Lines 12200 12206 +6
==========================================
+ Hits 10119 10123 +4
- Misses 2081 2083 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
reyang
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2803
Changes
Tracer.StartRootSpanso that it creates a root span even ifActivity.Current != nullMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes