Skip to content

Update OTLP Exporter README #4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Update OTLP Exporter README #4804

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9810f29
Update README
utpilla Aug 26, 2023
56344c3
Merge branch 'main' into utpilla/Update-OTLP-Exporter-README
utpilla Aug 28, 2023
51fa8d6
Update OTLP Exporter README
utpilla Aug 28, 2023
caa9d4d
Merge branch 'utpilla/Update-OTLP-Exporter-README' of https://github.…
utpilla Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ values of the `PeriodicExportingMetricReaderOptions`
| `OTEL_METRIC_EXPORT_INTERVAL` | `ExportIntervalMilliseconds` |
| `OTEL_METRIC_EXPORT_TIMEOUT` | `ExportTimeoutMilliseconds` |

NOTE: `OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE` is not supported yet [#3756](https://github.com/open-telemetry/opentelemetry-dotnet/issues/3756).
Copy link
Member

@vishweshbankwar vishweshbankwar Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mention with one liner that the environment variable is supported.

Copy link
Member

@cijothomas cijothomas Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also call out the values suported. I dont think we support all the values. (like lowmemory)

Copy link
Contributor Author

@utpilla utpilla Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is lowmemory?

Copy link

@austindrenski austindrenski Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cijothomas is support for LowMemory on the roadmap, or blocked by anything specific we can follow in the meantime?

Copy link
Member

@cijothomas cijothomas Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utpilla The above link has the spec for lowmemory.
@austindrenski I don't think there are any blockers implementing lowmemory. Its just that nobody asked for it so far! Could you open an issue for it to better track adding it!


The following environment variables can be used to override the default
values of the attribute limits
(following the [OpenTelemetry specification](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.15.0/specification/sdk-environment-variables.md#attribute-limits)).
Expand Down