-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentracing shim noop cases #4668
Opentracing shim noop cases #4668
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4668 +/- ##
==========================================
- Coverage 85.06% 85.03% -0.04%
==========================================
Files 314 314
Lines 12747 12721 -26
==========================================
- Hits 10843 10817 -26
Misses 1904 1904
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI failures seem unrelated to the change: |
Fixes #2787
Changes
TelemetrySpan.NoopInstance
has an invalid span context the shim should not raise an exception: it is an expected scenario.Activity
and various sampling configurations to prevent similar regressions in the future.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes