Skip to content

Add comments to package dependency to clarify the direction #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2023
Merged

Add comments to package dependency to clarify the direction #4550

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
472e9c0
Add comments to package dependency to clarify the direction
reyang Jun 6, 2023
6d4e08f
Merge branch 'main' into reyang/clarify-versioning-story
cijothomas Jun 6, 2023
cce9a7a
Merge branch 'main' into reyang/clarify-versioning-story
cijothomas Jun 7, 2023
26727bf
add more context
reyang Jun 7, 2023
ad8bf04
better example for .NET 8
reyang Jun 8, 2023
78c6eca
Merge branch 'main' into reyang/clarify-versioning-story
reyang Jun 8, 2023
6cfb898
Merge branch 'main' into reyang/clarify-versioning-story
utpilla Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,28 @@
<PackageVersion Include="MinVer" Version="[4.2.0,5.0)" />
<PackageVersion Include="OpenTracing" Version="[0.12.1,0.13)" />
<PackageVersion Include="StyleCop.Analyzers" Version="[1.2.0-beta.435,2.0)" />

<!--
Typically, the latest stable version of System.Diagnostics.DiagnosticSource should be used here because:
1) Each major version bump will have some new OpenTelemetry API capabilities (e.g. .NET 6 introduced Meter
API, .NET 7 added UpDownCounter, .NET 8 is adding Meter/Instrument level attributes support, .NET 9 might
add Advice/Hint API) that the OpenTelemetry components rely on.
2) Each minor version bump is normally security hotfixes or critical bug fixes.
3) The .NET runtime team provides extra backward compatibility guarantee to System.Diagnostics.DiagnosticSource
even during major version bumps, so compatibility is not a concern here.
-->
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="7.0.0" />

<!-- A conservative version of System.Reflection.Emit.Lightweight must be used here since there is no backward compatibility guarantee during major version bumps. -->
<PackageVersion Include="System.Reflection.Emit.Lightweight" Version="4.7.0" />

<!-- A conservative version of System.Text.Encodings.Web must be used here since there is no backward compatibility guarantee during major version bumps. -->
<PackageVersion Include="System.Text.Encodings.Web" Version="4.7.2" />

<!-- A conservative version of System.Text.Json must be used here since there is no backward compatibility guarantee during major version bumps. -->
<PackageVersion Include="System.Text.Json" Version="4.7.2" />

<!-- A conservative version of System.Threading.Tasks.Extensions must be used here since there is no backward compatibility guarantee during major version bumps. -->
<PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
</ItemGroup>

Expand Down