Fix AOT warnings for RuntimeContext #4542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4542 +/- ##
==========================================
- Coverage 85.58% 85.50% -0.09%
==========================================
Files 320 320
Lines 12615 12628 +13
==========================================
+ Hits 10796 10797 +1
- Misses 1819 1831 +12
|
reyang
approved these changes
Jun 2, 2023
Yun-Ting
approved these changes
Jun 2, 2023
4 tasks
Kielek
reviewed
Jun 5, 2023
alanwest
approved these changes
Jun 5, 2023
Member
alanwest
left a comment
alanwest
left a comment
There was a problem hiding this comment.
Just a suggestion to add context for why this change is being made.
Co-authored-by: Alan West <[email protected]>
…/github.com/utpilla/opentelemetry-dotnet into utpilla/Fix-AOT-Warnings-For-RuntimeContext
mfogliatto
pushed a commit
to mfogliatto/opentelemetry-dotnet
that referenced
this pull request
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3429
This PR introduces a Breaking change. This would no longer support assigning custom types to
RuntimeContext.ContextSlotType.Changes
RuntimeContextclassRuntimeContextSlot<T>Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes