Skip to content

Conversation

@CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 23, 2023

Relates to #4433

Changes

  • Adds internal artifacts to OpenTelemetry.Api for implementing the Logs Bridge API from spec (now stable but we'll keep everything internal for now)

  • Moves LogRecordData and LogRecordAttributeList from SDK into API

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
    * [X] Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team April 23, 2023 22:35
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #4422 (10ea13a) into main (ef0c921) will decrease coverage by 0.12%.
The diff coverage is 62.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4422      +/-   ##
==========================================
- Coverage   84.78%   84.67%   -0.12%     
==========================================
  Files         300      305       +5     
  Lines       12064    12089      +25     
==========================================
+ Hits        10229    10236       +7     
- Misses       1835     1853      +18     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/InstrumentationScope.cs 0.00% <0.00%> (ø)
src/OpenTelemetry.Api/Logs/Logger.cs 0.00% <0.00%> (ø)
src/OpenTelemetry.Api/Logs/LoggerProvider.cs 0.00% <0.00%> (ø)
...rc/OpenTelemetry.Api/Logs/LoggerProviderBuilder.cs 0.00% <0.00%> (ø)
src/OpenTelemetry.Api/Logs/NoopLogger.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 88.75% <ø> (ø)
...c/OpenTelemetry.Api/Logs/LogRecordAttributeList.cs 68.75% <68.75%> (ø)
src/OpenTelemetry.Api/Logs/LogRecordData.cs 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. We can get into the weeds as we begin exposing things.

@CodeBlanch CodeBlanch merged commit 6a64dd2 into open-telemetry:main Apr 25, 2023
@CodeBlanch CodeBlanch deleted the log-api branch April 25, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants