Skip to content

Conversation

@mfogliatto
Copy link
Contributor

Fixes #2873.

Changes

  • Adds the following unit tests in OtlpLogExporterTests to increase OtlpLogExporter's code coverage to ~100%:

    • Export_WhenExportClientIsProvidedInCtor_UsesProvidedExportClient
    • Export_WhenExportClientThrowsException_ReturnsExportResultFailure
    • Export_WhenExportIsSuccessful_ReturnsExportResultSuccess

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes N/A
  • Design discussion issue N/A
  • Changes in public API reviewed N/A

References

Codecov: https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs

@mfogliatto mfogliatto requested a review from a team March 11, 2023 08:10
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@utpilla
Copy link
Contributor

utpilla commented Mar 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@mfogliatto mfogliatto force-pushed the mfogliatto/add-otlplogexporter-tests-2 branch from 1da2791 to 7ec6d9a Compare March 15, 2023 13:38
@mfogliatto
Copy link
Contributor Author

mfogliatto commented Mar 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@cijothomas cijothomas merged commit 3d6656f into open-telemetry:main Mar 15, 2023
@mfogliatto mfogliatto deleted the mfogliatto/add-otlplogexporter-tests-2 branch April 29, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTLPLogExporter tests

3 participants