[Otlp] Bump Google.Protobuf to 3.22.0 and remove reflection emit code #4201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4201 +/- ##
==========================================
- Coverage 85.71% 85.69% -0.02%
==========================================
Files 289 289
Lines 11374 11346 -28
==========================================
- Hits 9749 9723 -26
+ Misses 1625 1623 -2
|
Contributor
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
cijothomas
removed
the
Stale
cijothomas
approved these changes
Feb 24, 2023
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
LGTM. A changelog entry is needed as we bump minimum version of protobuf.
Member
Author
|
@cijothomas CHANGELOG updated. |
reyang
approved these changes
Feb 25, 2023
This was referenced Apr 17, 2023
alanwest
added a commit
to alanwest/opentelemetry-dotnet
that referenced
this pull request
Apr 19, 2023
…mit code (open-telemetry#4201)" This reverts commit f7f5358.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This could go in 1.4 but I think leave it out just so we can soak the 3.22.0 bump for a bit to make sure there are no unexpected issues.]Changes
A while back we were able to get a change put into Protobuf to make the default clear behavior capacity-preserving. That is now available in 3.22.0 and allows us to remove the reflection emit perf hacks.
TODOs
CHANGELOG.mdupdated for non-trivial changes