Skip to content

[DI] Rename DI package to OpenTelemetry.Api.ProviderBuilderExtensions #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2023
Merged

[DI] Rename DI package to OpenTelemetry.Api.ProviderBuilderExtensions #4125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa5c1e4
Rename DI package to OpenTelemetry.Api.ProviderBuilderExtensions.
CodeBlanch Jan 31, 2023
f4cd025
Patch CHANGELOG.
CodeBlanch Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions OpenTelemetry.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,9 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Exporter.Open
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Exporter.Console.Tests", "test\OpenTelemetry.Exporter.Console.Tests\OpenTelemetry.Exporter.Console.Tests.csproj", "{011E70E1-152A-47BB-AF83-12DD12B125ED}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Extensions.DependencyInjection", "src\OpenTelemetry.Extensions.DependencyInjection\OpenTelemetry.Extensions.DependencyInjection.csproj", "{171A87CB-393C-4296-913F-E704CD8CEAE9}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Api.ProviderBuilderExtensions", "src\OpenTelemetry.Api.ProviderBuilderExtensions\OpenTelemetry.Api.ProviderBuilderExtensions.csproj", "{171A87CB-393C-4296-913F-E704CD8CEAE9}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Extensions.DependencyInjection.Tests", "test\OpenTelemetry.Extensions.DependencyInjection.Tests\OpenTelemetry.Extensions.DependencyInjection.Tests.csproj", "{662476AA-5875-4E74-B992-DDF309168EFB}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Api.ProviderBuilderExtensions.Tests", "test\OpenTelemetry.Api.ProviderBuilderExtensions.Tests\OpenTelemetry.Api.ProviderBuilderExtensions.Tests.csproj", "{662476AA-5875-4E74-B992-DDF309168EFB}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "getting-started-aspnetcore", "docs\trace\getting-started-aspnetcore\getting-started-aspnetcore.csproj", "{DEDE8442-03CA-48CF-99B9-EA224D89D148}"
EndProject
Expand Down
0 ...n/.publicApi/net462/PublicAPI.Shipped.txt → ...s/.publicApi/net462/PublicAPI.Shipped.txt
View file
Open in desktop
File renamed without changes.
0 ....publicApi/net462/PublicAPI.Unshipped.txt → ....publicApi/net462/PublicAPI.Unshipped.txt
View file
Open in desktop
File renamed without changes.
0 ...cApi/netstandard2.0/PublicAPI.Shipped.txt → ...cApi/netstandard2.0/PublicAPI.Shipped.txt
View file
Open in desktop
File renamed without changes.
0 ...pi/netstandard2.0/PublicAPI.Unshipped.txt → ...pi/netstandard2.0/PublicAPI.Unshipped.txt
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...sions.DependencyInjection/AssemblyInfo.cs → ...ProviderBuilderExtensions/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@

[assembly: InternalsVisibleTo("OpenTelemetry" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("OpenTelemetry.Tests" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("OpenTelemetry.Extensions.DependencyInjection.Tests" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("OpenTelemetry.Api.ProviderBuilderExtensions.Tests" + AssemblyInfo.PublicKey)]
4 changes: 4 additions & 0 deletions ...tensions.DependencyInjection/CHANGELOG.md → ...pi.ProviderBuilderExtensions/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
* Removed `ConfigureBuilder` from the public API.
([#4103](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4103))

* Renamed package from `OpenTelemetry.Extensions.DependencyInjection` to
`OpenTelemetry.Api.ProviderBuilderExtensions`.
([#4125](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4125))

## 1.4.0-rc.2

Released 2023-Jan-09
Expand Down
0 ...Metrics/IConfigureMeterProviderBuilder.cs → ...Metrics/IConfigureMeterProviderBuilder.cs
View file
Open in desktop
File renamed without changes.
0 ...njection/Metrics/IMeterProviderBuilder.cs → ...tensions/Metrics/IMeterProviderBuilder.cs
View file
Open in desktop
File renamed without changes.
0 ...njectionMeterProviderBuilderExtensions.cs → ...njectionMeterProviderBuilderExtensions.cs
View file
Open in desktop
File renamed without changes.
0 ...tionMetricsServiceCollectionExtensions.cs → ...tionMetricsServiceCollectionExtensions.cs
View file
Open in desktop
File renamed without changes.
0 ...try.Extensions.DependencyInjection.csproj → ...etry.Api.ProviderBuilderExtensions.csproj
View file
Open in desktop
File renamed without changes.
27 changes: 27 additions & 0 deletions src/OpenTelemetry.Api.ProviderBuilderExtensions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# OpenTelemetry.Api.ProviderBuilderExtensions

[![NuGet](https://img.shields.io/nuget/v/OpenTelemetry.Api.ProviderBuilderExtensions.svg)](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions)
[![NuGet](https://img.shields.io/nuget/dt/OpenTelemetry.Api.ProviderBuilderExtensions.svg)](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions)

## Installation

```shell
dotnet add package --prerelease OpenTelemetry.Api.ProviderBuilderExtensions
```

## Overview

The `OpenTelemetry.Api.ProviderBuilderExtensions` package provides extension
methods and helpers for building `TracerProvider`s and `MeterProvider`s using
the `Microsoft.Extensions.DependencyInjection` API (primarily
[IServiceCollection](https://learn.microsoft.com/dotnet/api/microsoft.extensions.dependencyinjection.iservicecollection)).

The `OpenTelemetry.Api.ProviderBuilderExtensions` package is intended for
instrumentation library authors who need to integrate with the OpenTelemetry SDK
Copy link
Member

@cijothomas cijothomas Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"who need to provide DI based configuration, but without taking OTel SDK dependency.. "

Feel free to grab this/similar, in a separate PR if needed.

without a direct dependency. For more details see: [Registration extension
method guidance for library
authors](../../docs/trace/extending-the-sdk/README.md#registration-extension-method-guidance-for-library-authors).

## References

* [OpenTelemetry Project](https://opentelemetry.io/)
0 .../Trace/IConfigureTracerProviderBuilder.cs → .../Trace/IConfigureTracerProviderBuilder.cs
View file
Open in desktop
File renamed without changes.
0 ...Injection/Trace/ITracerProviderBuilder.cs → ...xtensions/Trace/ITracerProviderBuilder.cs
View file
Open in desktop
File renamed without changes.
0 ...jectionTracerProviderBuilderExtensions.cs → ...jectionTracerProviderBuilderExtensions.cs
View file
Open in desktop
File renamed without changes.
0 ...tionTracingServiceCollectionExtensions.cs → ...tionTracingServiceCollectionExtensions.cs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Api/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("OpenTelemetry" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("OpenTelemetry.Extensions.DependencyInjection" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("OpenTelemetry.Api.ProviderBuilderExtensions" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("OpenTelemetry.Tests" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("OpenTelemetry.Shims.OpenTracing.Tests" + AssemblyInfo.PublicKey)]
[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2" + AssemblyInfo.MoqPublicKey)]
Expand Down
25 changes: 0 additions & 25 deletions src/OpenTelemetry.Extensions.DependencyInjection/README.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.SqlClient/OpenTelemetry.Instrumentation.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Extensions.DependencyInjection\OpenTelemetry.Extensions.DependencyInjection.csproj" />
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Api.ProviderBuilderExtensions\OpenTelemetry.Api.ProviderBuilderExtensions.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry/OpenTelemetry.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Extensions.DependencyInjection\OpenTelemetry.Extensions.DependencyInjection.csproj" />
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Api.ProviderBuilderExtensions\OpenTelemetry.Api.ProviderBuilderExtensions.csproj" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion ...ts/MeterProviderBuilderExtensionsTests.cs → ...ts/MeterProviderBuilderExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
using OpenTelemetry.Metrics;
using Xunit;

namespace OpenTelemetry.Extensions.DependencyInjection.Tests;
namespace OpenTelemetry.Api.ProviderBuilderExtensions.Tests;

public class MeterProviderBuilderExtensionsTests
{
Expand Down
2 changes: 1 addition & 1 deletion ...tensions.DependencyInjection.Tests.csproj → ...pi.ProviderBuilderExtensions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Extensions.DependencyInjection\OpenTelemetry.Extensions.DependencyInjection.csproj" />
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.Api.ProviderBuilderExtensions\OpenTelemetry.Api.ProviderBuilderExtensions.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...Tests/ServiceCollectionExtensionsTests.cs → ...Tests/ServiceCollectionExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
using OpenTelemetry.Trace;
using Xunit;

namespace OpenTelemetry.Extensions.DependencyInjection.Tests;
namespace OpenTelemetry.Api.ProviderBuilderExtensions.Tests;

public class ServiceCollectionExtensionsTests
{
Expand Down
2 changes: 1 addition & 1 deletion ...jection.Tests/TestMeterProviderBuilder.cs → ...ensions.Tests/TestMeterProviderBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
using Microsoft.Extensions.DependencyInjection;
using OpenTelemetry.Metrics;

namespace OpenTelemetry.Extensions.DependencyInjection.Tests;
namespace OpenTelemetry.Api.ProviderBuilderExtensions.Tests;

public sealed class TestMeterProviderBuilder : MeterProviderBuilder, IMeterProviderBuilder, IDisposable
{
Expand Down
2 changes: 1 addition & 1 deletion ...ection.Tests/TestTracerProviderBuilder.cs → ...nsions.Tests/TestTracerProviderBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
using Microsoft.Extensions.DependencyInjection;
using OpenTelemetry.Trace;

namespace OpenTelemetry.Extensions.DependencyInjection.Tests;
namespace OpenTelemetry.Api.ProviderBuilderExtensions.Tests;

public sealed class TestTracerProviderBuilder : TracerProviderBuilder, ITracerProviderBuilder, IDisposable
{
Expand Down
2 changes: 1 addition & 1 deletion ...s/TracerProviderBuilderExtensionsTests.cs → ...s/TracerProviderBuilderExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
using OpenTelemetry.Trace;
using Xunit;

namespace OpenTelemetry.Extensions.DependencyInjection.Tests;
namespace OpenTelemetry.Api.ProviderBuilderExtensions.Tests;

public class TracerProviderBuilderExtensionsTests
{
Expand Down