[Hosting] Remove obsolete methods ahead of 1.4.0 release

src/OpenTelemetry.Extensions.DependencyInjection/README.md

@@ -6,7 +6,7 @@
 ## Installation
 
 ```shell
-dotnet add package --prerelease OpenTelemetry.Extensions.DependencyInjection
+dotnet add package OpenTelemetry.Extensions.DependencyInjection
 ```
 
 ## Overview

src/OpenTelemetry.Extensions.Hosting/.publicApi/netstandard2.0/PublicAPI.Shipped.txt

@@ -0,0 +1 @@
+#nullable enable

src/OpenTelemetry.Extensions.Hosting/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt

@@ -1,13 +1,2 @@
-Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions
-OpenTelemetry.Metrics.MeterProviderBuilderExtensions
 OpenTelemetry.OpenTelemetryBuilderHostingExtensions
-OpenTelemetry.Trace.TracerProviderBuilderExtensions
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryMetrics(this Microsoft.Extensions.DependencyInjection.IServiceCollection services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryMetrics(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Action<OpenTelemetry.Metrics.MeterProviderBuilder> configure) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryTracing(this Microsoft.Extensions.DependencyInjection.IServiceCollection services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryTracing(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Action<OpenTelemetry.Trace.TracerProviderBuilder> configure) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
-static OpenTelemetry.Metrics.MeterProviderBuilderExtensions.Configure(this OpenTelemetry.Metrics.MeterProviderBuilder meterProviderBuilder, System.Action<System.IServiceProvider, OpenTelemetry.Metrics.MeterProviderBuilder> configure) -> OpenTelemetry.Metrics.MeterProviderBuilder
-static OpenTelemetry.Metrics.MeterProviderBuilderExtensions.GetServices(this OpenTelemetry.Metrics.MeterProviderBuilder meterProviderBuilder) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
-static OpenTelemetry.OpenTelemetryBuilderHostingExtensions.StartWithHost(this OpenTelemetry.OpenTelemetryBuilder builder) -> OpenTelemetry.OpenTelemetryBuilder
-static OpenTelemetry.Trace.TracerProviderBuilderExtensions.Configure(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder, System.Action<System.IServiceProvider, OpenTelemetry.Trace.TracerProviderBuilder> configure) -> OpenTelemetry.Trace.TracerProviderBuilder
-static OpenTelemetry.Trace.TracerProviderBuilderExtensions.GetServices(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
+static OpenTelemetry.OpenTelemetryBuilderHostingExtensions.StartWithHost(this OpenTelemetry.OpenTelemetryBuilder! builder) -> OpenTelemetry.OpenTelemetryBuilder!

src/OpenTelemetry.Extensions.Hosting/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+* Removed deprecated extensions: `AddOpenTelemetryTracing`,
+  `AddOpenTelemetryMetrics`, `Configure`, & `GetServices`.
+  ([#4071](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4071))
+
 ## 1.4.0-rc.2
 
 Released 2023-Jan-09

src/OpenTelemetry.Extensions.Hosting/Implementation/TelemetryHostedService.cs

@@ -49,13 +49,13 @@ internal static void Initialize(IServiceProvider serviceProvider)
     {
         Debug.Assert(serviceProvider != null, "serviceProvider was null");
 
-        var meterProvider = serviceProvider.GetService<MeterProvider>();
+        var meterProvider = serviceProvider!.GetService<MeterProvider>();
         if (meterProvider == null)
         {
             HostingExtensionsEventSource.Log.MeterProviderNotRegistered();
         }
 
-        var tracerProvider = serviceProvider.GetService<TracerProvider>();
+        var tracerProvider = serviceProvider!.GetService<TracerProvider>();
         if (tracerProvider == null)
         {
             HostingExtensionsEventSource.Log.TracerProviderNotRegistered();

src/OpenTelemetry.Extensions.Hosting/OpenTelemetry.Extensions.Hosting.csproj

@@ -1,13 +1,12 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
+
   <PropertyGroup>
     <!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. -->
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <Description>Contains extensions to start OpenTelemetry in applications using Microsoft.Extensions.Hosting</Description>
     <RootNamespace>OpenTelemetry</RootNamespace>
     <MinVerTagPrefix>core-</MinVerTagPrefix>
-
-    <!-- this is temporary. will remove in future PR. -->
-    <Nullable>disable</Nullable>
+    <AnalysisLevel>latest-all</AnalysisLevel>
   </PropertyGroup>
 
   <!--Do not run ApiCompat for netstandard2.0 as this is newly added. Remove this property once we have released a stable version.-->
@@ -17,8 +16,13 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="$(MicrosoftExtensionsHostingAbstractionsPkgVer)" />
+  </ItemGroup>
+
+  <ItemGroup>
     <ProjectReference Include="$(RepoRoot)\src\OpenTelemetry\OpenTelemetry.csproj" />
+  </ItemGroup>
 
+  <ItemGroup>
     <Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\ExceptionExtensions.cs" Link="Includes\ExceptionExtensions.cs" />
     <Compile Include="$(RepoRoot)\src\OpenTelemetry.Api\Internal\Guard.cs" Link="Includes\Guard.cs" />
   </ItemGroup>

src/OpenTelemetry.Extensions.Hosting/README.md

@@ -6,7 +6,7 @@
 ## Installation
 
 ```shell
-dotnet add package --prerelease OpenTelemetry.Extensions.Hosting
+dotnet add package OpenTelemetry.Extensions.Hosting
 ```
 
 ## Overview
@@ -21,7 +21,7 @@ and metrics (`MeterProvider`) in [ASP.NET
 
 ## Extension method reference
 
-### Current OpenTelemetry SDK v1.4.0 and newer extensions
+### OpenTelemetry SDK v1.4.0 and newer extensions
 
 Targeting `OpenTelemetry.OpenTelemetryBuilder`:
 
@@ -30,7 +30,32 @@ Targeting `OpenTelemetry.OpenTelemetryBuilder`:
   to automatically start tracing and/or metric services in the supplied
   [IServiceCollection](https://learn.microsoft.com/dotnet/api/microsoft.extensions.dependencyinjection.iservicecollection).
 
-### Obsolete OpenTelemetry SDK pre-1.4.0 extensions
+#### Usage
+
+The following example shows how to register OpenTelemetry tracing & metrics in
+an ASP.NET Core host using the OpenTelemetry.Extensions.Hosting extensions.
+
+```csharp
+using Microsoft.AspNetCore.Builder;
+using Microsoft.Extensions.DependencyInjection;
+using OpenTelemetry.Metrics;
+using OpenTelemetry.Trace;
+
+var appBuilder = WebApplication.CreateBuilder(args);
+
+appBuilder.Services.AddOpenTelemetry()
+    .WithTracing(builder => builder.AddConsoleExporter())
+    .WithMetrics(builder => builder.AddConsoleExporter())
+    .StartWithHost();
+
+var app = appBuilder.Build();
+
+app.Run();
+```
+
+### OpenTelemetry SDK v1.3.0 and older extensions
+
+**Note:** The below extension methods were removed in v1.4.0.
 
 **Note:** The below extension methods should be called by application host code
 only. Library authors see: [Registration extension method guidance for library
@@ -57,29 +82,6 @@ Targeting `Microsoft.Extensions.DependencyInjection.IServiceCollection`:
   to automatically start metric services in the supplied
   [IServiceCollection](https://learn.microsoft.com/dotnet/api/microsoft.extensions.dependencyinjection.iservicecollection).
 
-## Usage
-
-The following example shows how to register OpenTelemetry tracing & metrics in
-an ASP.NET Core host using the OpenTelemetry.Extensions.Hosting extensions.
-
-```csharp
-using Microsoft.AspNetCore.Builder;
-using Microsoft.Extensions.DependencyInjection;
-using OpenTelemetry.Metrics;
-using OpenTelemetry.Trace;
-
-var appBuilder = WebApplication.CreateBuilder(args);
-
-appBuilder.Services.AddOpenTelemetry()
-    .WithTracing(builder => builder.AddConsoleExporter())
-    .WithMetrics(builder => builder.AddConsoleExporter())
-    .StartWithHost();
-
-var app = appBuilder.Build();
-
-app.Run();
-```
-
 ## References
 
 * [OpenTelemetry Project](https://opentelemetry.io/)