Skip to content

Conversation

@CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Dec 9, 2022

Changes

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team December 9, 2022 00:10
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #3994 (de18f74) into main (723ad0b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3994      +/-   ##
==========================================
+ Coverage   85.40%   85.41%   +0.01%     
==========================================
  Files         289      289              
  Lines       11228    11236       +8     
==========================================
+ Hits         9589     9597       +8     
  Misses       1639     1639              
Impacted Files Coverage Δ
...ation.SqlClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)

@CodeBlanch CodeBlanch merged commit 8d908b9 into open-telemetry:main Dec 9, 2022
@CodeBlanch CodeBlanch deleted the sql-client-options branch December 9, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants