[Exporter.OpenTelemetryProtocol] SdkOptionLimits - fix defaults #3978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
force-pushed
the
sdk-limit-options-sync-with-spec
branch
from
94c42dc to
0c215d6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3978 +/- ##
==========================================
- Coverage 85.58% 85.54% -0.05%
==========================================
Files 288 288
Lines 11070 11080 +10
==========================================
+ Hits 9474 9478 +4
- Misses 1596 1602 +6
|
pellared
approved these changes
Dec 7, 2022
alanwest
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
LGTM. We'd originally punted on adopting the defaults because technically this could be considered a breaking change. Though, I'm not really concerned 128 is a pretty generous default and I'd suspect have low chance of impacting many users. Also, I think it's fair to frame this as a bug fix.
pjanotti
pushed a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Dec 13, 2022
* Bump OTel to 1.4.0-rc.1 * ConfigureResource api was removed in open-telemetry/opentelemetry-dotnet#3999 * Update limits based on open-telemetry/opentelemetry-dotnet#3978 * Fix build structure OpenTelemetry references OpenTelemetry.Extensions.DependencyInjection package * Fix ModuleTests * Handle AspNetCore metrics changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3962.
Changes
Fix default values for
OTEL_ATTRIBUTE_COUNT_LIMIT,OTEL_ATTRIBUTE_COUNT_LIMIT,OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT,OTEL_SPAN_EVENT_COUNT_LIMIT,OTEL_SPAN_LINK_COUNT_LIMIT,OTEL_EVENT_ATTRIBUTE_COUNT_LIMIT,OTEL_LINK_ATTRIBUTE_COUNT_LIMIT. All of them are defaulted to128.CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed