-
Notifications
You must be signed in to change notification settings - Fork 855
Try asp.net core tests with inproc server #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cijothomas
merged 5 commits into
open-telemetry:main
from
cijothomas:cijothomas/aspnetcoreinproc
Jun 22, 2022
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ff6adb4
Try asp.net core tests with inproc server
cijothomas 0c31e57
await
cijothomas d4997ea
Merge branch 'main' into cijothomas/aspnetcoreinproc
cijothomas 2773b5b
Update test/OpenTelemetry.Instrumentation.AspNetCore.Tests/InProcServ…
cijothomas b701277
Update test/OpenTelemetry.Instrumentation.AspNetCore.Tests/InProcServ…
cijothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
88 changes: 88 additions & 0 deletions
88
test/OpenTelemetry.Instrumentation.AspNetCore.Tests/InProcServerTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // <copyright file="InProcServerTests.cs" company="OpenTelemetry Authors"> | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // </copyright> | ||
|
|
||
| #if NET6_0_OR_GREATER | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
| using System.Net.Http; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.AspNetCore.Builder; | ||
| using OpenTelemetry.Trace; | ||
| using Xunit; | ||
|
|
||
| namespace OpenTelemetry.Instrumentation.AspNetCore.Tests | ||
| { | ||
| public sealed class InProcServerTests : IDisposable | ||
| { | ||
| private TracerProvider tracerProvider; | ||
| private WebApplication app; | ||
| private HttpClient client; | ||
| private List<Activity> exportedItems; | ||
|
|
||
| public InProcServerTests() | ||
| { | ||
| this.exportedItems = new List<Activity>(); | ||
| var builder = WebApplication.CreateBuilder(); | ||
| var app = builder.Build(); | ||
|
|
||
| this.tracerProvider = Sdk.CreateTracerProviderBuilder() | ||
| .AddAspNetCoreInstrumentation() | ||
| .AddInMemoryExporter(this.exportedItems).Build(); | ||
| app.MapGet("/", () => "Hello World!"); | ||
| app.RunAsync(); | ||
|
|
||
| this.app = app; | ||
| this.client = new HttpClient(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async void ExampleTest() | ||
| { | ||
| var res = await this.client.GetStringAsync("http://localhost:5000"); | ||
| Assert.NotNull(res); | ||
|
|
||
| this.tracerProvider.ForceFlush(); | ||
| for (var i = 0; i < 10; i++) | ||
| { | ||
| if (this.exportedItems.Count > 0) | ||
| { | ||
| break; | ||
| } | ||
|
|
||
| // We need to let End callback execute as it is executed AFTER response was returned. | ||
| // In unit tests environment there may be a lot of parallel unit tests executed, so | ||
| // giving some breezing room for the End callback to complete | ||
| await Task.Delay(TimeSpan.FromSeconds(1)); | ||
| } | ||
|
|
||
| var activity = this.exportedItems[0]; | ||
| Assert.Equal(ActivityKind.Server, activity.Kind); | ||
| Assert.Equal("localhost:5000", activity.GetTagValue(SemanticConventions.AttributeHttpHost)); | ||
| Assert.Equal("GET", activity.GetTagValue(SemanticConventions.AttributeHttpMethod)); | ||
| Assert.Equal("1.1", activity.GetTagValue(SemanticConventions.AttributeHttpFlavor)); | ||
| Assert.Equal(200, activity.GetTagValue(SemanticConventions.AttributeHttpStatusCode)); | ||
| } | ||
|
|
||
| public async void Dispose() | ||
cijothomas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| this.tracerProvider.Dispose(); | ||
| this.client.Dispose(); | ||
| await this.app.DisposeAsync(); | ||
| } | ||
| } | ||
| } | ||
| #endif | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.