Update changelog with more details for gRPC support #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
reviewed
Aug 5, 2020
| @@ -3,6 +3,12 @@ | |||
| ## Unreleased | |||
|
|
|||
| * Introduced support for Grpc.AspNetCore (#803). | |||
| * Attributes are added to gRPC invocations: `rpc.system`, `rpc.service`, | |||
| `rpc.method`. These attributes are are added to an existing span generated | |||
There was a problem hiding this comment.
Arrrr, matey! Good catch. 🏴☠️
eddynaka
reviewed
Aug 5, 2020
| by the instrumentation. This is unlike the instrumentation for client-side | ||
| gRPC calls where one span is created for the gRPC call and a separate span | ||
| is created for the underlying HTTP call in the event both gRPC and HTTP | ||
| instrumentation is enabled. |
There was a problem hiding this comment.
Maybe we should switch from is enabled to "are enabled". I'm not sure (english isn't my first language)...
There was a problem hiding this comment.
Arrrr! Your English is perfect.
eddynaka
approved these changes
Aug 5, 2020
cijothomas
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cijothomas Additional details based on our conversation. Sorry, forgot to include in #803.