Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "/" in instrument names #4877

Closed
reyang opened this issue Sep 22, 2023 · 0 comments · Fixed by #4882
Closed

Support "/" in instrument names #4877

reyang opened this issue Sep 22, 2023 · 0 comments · Fixed by #4882
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics Metrics signal related

Comments

@reyang
Copy link
Member

reyang commented Sep 22, 2023

Feature Request

The spec has changed open-telemetry/opentelemetry-specification#3684.
The expected code change should be similar to what's been done in #4798.
@reyang reyang added enhancement New feature or request metrics Metrics signal related help wanted Good for taking. Extra help will be provided by maintainers labels Sep 22, 2023
@cijothomas cijothomas added the good first issue Good for newcomers label Sep 24, 2023
tombiddulph added a commit to tombiddulph/opentelemetry-dotnet that referenced this issue Sep 24, 2023
@tombiddulph
Allow / in metric instrument names
ec88674 
Updates the regex in `MeterProviderBuilderSdk.cs` to allow metric instrument names to contain `/` characters. This is in response to the issue raised in [open-telemetry#4887](open-telemetry#4877). Now, metric names like `my_metric/environment/database` can be used. Corresponding changes are also made to the tests and CHANGELOG.md.
@tombiddulph tombiddulph mentioned this issue Sep 24, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics Metrics signal related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[sdk] Allow / in metric instrument names tombiddulph/opentelemetry-dotnet
2 participants
@cijothomas @reyang