[WCF] Fix WCF instrumentation initialization #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
reviewed
Sep 19, 2024
test/test-applications/integrations/TestApplication.Owin.IIS/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
pjanotti
approved these changes
Sep 19, 2024
nrcventura
approved these changes
Sep 19, 2024
Kielek
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #3589
What
Linked issue stems from the fact that WCF instrumentation initialization was run when
System.ServiceModelassembly was loaded. Initialization included setting up WCF instrumentation options, and initializing parent span correction feature. This feature hooks into ASP.NET instrumentation, modifies the request headers and assumes request headers are read-only.This was causing issues for OWIN app hosed in IIS that attempted to modify request headers with a OWIN middleware.
This PR moves initialization to bytecode instrumentation.
Tests
Included in PR.
Checklist
CHANGELOG.mdis updated.- [ ] Documentation is updated.