Add signal based OTLP configuration#3527
Merged
Merged
Conversation
RassK
commented
Jul 23, 2024
# Conflicts: # CHANGELOG.md # src/OpenTelemetry.AutoInstrumentation/Configurations/LogSettings.cs # src/OpenTelemetry.AutoInstrumentation/Configurations/MetricSettings.cs # src/OpenTelemetry.AutoInstrumentation/Configurations/TracerSettings.cs # src/OpenTelemetry.AutoInstrumentation/Logger/LogBuilderExtensions.cs # test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/SettingsTests.cs
nrcventura
approved these changes
Jul 25, 2024
Kielek
reviewed
Jul 26, 2024
Member
|
@RassK, could you please resolve confilcts? |
# Conflicts: # CHANGELOG.md # src/OpenTelemetry.AutoInstrumentation/Configurations/LogSettings.cs # src/OpenTelemetry.AutoInstrumentation/Configurations/MetricSettings.cs # src/OpenTelemetry.AutoInstrumentation/Configurations/TracerSettings.cs # test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/SettingsTests.cs
Kielek
approved these changes
Jul 29, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Adds signal based OTLP exporter configuration variables.
SDK
Related issue:
open-telemetry/opentelemetry-dotnet#5429
What
Signal specified variables have higher priority than default variables. Auto instrumentation is using more detailed variables and overwrites options, default variable handling is left to SDK.
Full list of supported variables:
Tests
Extended some existing ones.
Checklist
CHANGELOG.mdis updated.