Skip to content
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,77 @@
// limitations under the License.
// </copyright>

using System.Diagnostics;
using System.Reflection;
using OpenTelemetry.AutoInstrumentation.Logging;

namespace OpenTelemetry.AutoInstrumentation.RulesEngine;

internal class DiagnosticSourceRule : Rule
{
private static readonly IOtelLogger Logger = OtelLogging.GetLogger("StartupHook");

public DiagnosticSourceRule()
{
Name = "System.Diagnostics.DiagnosticSource Validator";
Description = "Ensure that the System.Diagnostics.DiagnosticSource version is not older than the version used by the Auto-Instrumentation";
}

internal override bool Evaluate()
{
// TODO: implement checking logic
string? olderDiagnosticSourcePackageVersion = null;

try
{
var loadedDiagnosticSourceFileVersion = GetVersionFromApp();
if (loadedDiagnosticSourceFileVersion != null)
{
var autoInstrumentationDiagnosticSourceFileVersion = GetVersionFromAutoInstrumentation();
if (loadedDiagnosticSourceFileVersion < autoInstrumentationDiagnosticSourceFileVersion)
{
olderDiagnosticSourcePackageVersion = autoInstrumentationDiagnosticSourceFileVersion.ToString();
}
}
}
catch (Exception ex)
{
// Exception in evaluation should not throw or crash the process.
Logger.Warning($"Couldn't evaluate reference to System.Diagnostics.DiagnosticSource in an app. Exception: {ex}");
}

if (olderDiagnosticSourcePackageVersion != null)
{
Logger.Error($"Application has direct or indirect reference to older version of System.Diagnostics.DiagnosticSource.dll {olderDiagnosticSourcePackageVersion}.");
return false;
}

return true;
}

protected virtual Version? GetVersionFromApp()
{
// Look up for type with an assembly name, will load the library.
// The loaded version depends on the app's reference to the package.
var diagnosticSourceType = Type.GetType("System.Diagnostics.DiagnosticSource, System.Diagnostics.DiagnosticSource");
if (diagnosticSourceType != null)
{
var loadedDiagnosticSourceAssembly = Assembly.GetAssembly(diagnosticSourceType);
var loadedDiagnosticSourceAssemblyFileVersionAttribute = loadedDiagnosticSourceAssembly?.GetCustomAttribute<AssemblyFileVersionAttribute>();
var versionString = loadedDiagnosticSourceAssemblyFileVersionAttribute?.Version;
if (versionString != null)
{
return new Version(versionString);
}
}

return null;
}

protected virtual Version? GetVersionFromAutoInstrumentation()
{
var autoInstrumentationDiagnosticSourceLocation = Path.Combine(StartupHook.LoaderAssemblyLocation ?? string.Empty, "System.Diagnostics.DiagnosticSource.dll");
var autoInstrumentationDiagnosticSourceFileVersionInfo = FileVersionInfo.GetVersionInfo(autoInstrumentationDiagnosticSourceLocation);
var autoInstrumentationDiagnosticSourceFileVersion = new Version(autoInstrumentationDiagnosticSourceFileVersionInfo.FileVersion);
return autoInstrumentationDiagnosticSourceFileVersion;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// <copyright file="DiagnosticSourceRuleTests.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// </copyright>

using OpenTelemetry.AutoInstrumentation.RulesEngine;
using Xunit;

namespace OpenTelemetry.AutoInstrumentation.StartupHook.Tests;
public class DiagnosticSourceRuleTests
{
[Theory]
[InlineData("6.0.0.0", "7.0.0.0", false)]
[InlineData("8.0.0.0", "7.0.0.0", true)]
[InlineData("7.0.0.0", "7.0.0.0", true)]
public void DiagnosticSourceVersion(string appVersion, string autoInstrumentationVersion, bool result)
{
var rule = new TestableDiagnosticSourceRule(appVersion, autoInstrumentationVersion);
Assert.Equal(rule.Evaluate(), result);
}
}

internal class TestableDiagnosticSourceRule : DiagnosticSourceRule
{
private readonly string appVersion;
private readonly string autoInstrumentationVersion;

public TestableDiagnosticSourceRule(string appVersion, string autoInstrumentationVersion)
{
this.appVersion = appVersion;
this.autoInstrumentationVersion = autoInstrumentationVersion;
}

protected override Version? GetVersionFromApp()
{
return new Version(appVersion);
}

protected override Version? GetVersionFromAutoInstrumentation()
{
return new Version(autoInstrumentationVersion);
}
}