Make dotnet CLI issue more visible in the docs #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI failure on mac seems infrastructure flakiness, see https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/4048439221/jobs/6963680274#step:7:10 Re-running it ... |
Kielek
approved these changes
Jan 31, 2023
pellared
approved these changes
Jan 31, 2023
| #!/bin/sh | ||
|
|
||
| # guess OS_TYPE if not provided | ||
| OS_TYPE=${OS_TYPE:-} |
Contributor
Author
There was a problem hiding this comment.
Ops, this was to be part of #2129 to keep the code consistent between the two scripts. Without that the script fails on if [ -z "$OS_TYPE" ]; then: it doesn't like that test without defining OS_TYPE first.
theletterf
reviewed
Jan 31, 2023
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Minimize the chances of people hitting known issues with self-contained and
dotnetCLI in particular.What
Added explicit text to README.md in the
Get startedsection.Tests
N/A.
Checklist
- [ ]CHANGELOG.mdis updated.- [ ] New features are covered by tests.