Handle exception while opening connection from constructor #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing socket connection from ctr * Remove connect method and some nits --------- Co-authored-by: Arun Mohan Kumar <[email protected]>
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang,
utpilla and
Yun-Ting
2 tasks
reyang
approved these changes
Jan 28, 2023
reyang
reviewed
Jan 28, 2023
cijothomas
reviewed
Jan 28, 2023
src/OpenTelemetry.Exporter.Geneva/MsgPackExporter/Transport/UnixDomainSocketDataTransport.cs
Outdated
Show resolved
Hide resolved
Kielek
added
the
comp:exporter.geneva
cijothomas
approved these changes
Jan 30, 2023
|
Thanks! Given we are in RC state right now, we might hold off merging until 1.4.0 stable is out, so we'll get some time to test this. |
2 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
reyang
approved these changes
Feb 21, 2023
Kielek
reviewed
Feb 21, 2023
…/arunmk-ms/opentelemetry-dotnet-contrib into personal/arunmk-ms/socketchanges
utpilla
reviewed
Feb 23, 2023
utpilla
approved these changes
Feb 23, 2023
cijothomas
reviewed
Feb 25, 2023
cijothomas
reviewed
Feb 25, 2023
|
@arunmk-ms We released the stable 1.4.0 version of GenevaExporter. Could you please resolve the merge conflicts, and we can get this PR merged? |
|
@utpilla done |
|
Thanks for your contribution @arunmk-ms ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Issue 934
Changes
Add try/catch to the socket connection in constructor so that the application wont fail fast when the UDS is not available at startup.