-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Update scopes #736
Merged
utpilla
merged 6 commits into
open-telemetry:main
from
utpilla:utpilla/Update-GenevaLogExporter-for-Scopes
Oct 28, 2022
Merged
[Exporter.Geneva] Update scopes #736
utpilla
merged 6 commits into
open-telemetry:main
from
utpilla:utpilla/Update-GenevaLogExporter-for-Scopes
Oct 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
- Coverage 77.55% 77.38% -0.17%
==========================================
Files 176 176
Lines 5298 5294 -4
==========================================
- Hits 4109 4097 -12
- Misses 1189 1197 +8
|
cijothomas
reviewed
Oct 27, 2022
cijothomas
reviewed
Oct 27, 2022
cijothomas
reviewed
Oct 28, 2022
cijothomas
approved these changes
Oct 28, 2022
Related to #389 |
This was referenced Dec 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting scopes in GenevaExporter:
"{OriginalFormat"}
) will not be exportedExamples
1. Key is null
No scopes are exported in this case as there is no key provided for the scope.
2. Using formatted string in scopes
Scopes exported:
3. Using
IEnumerable<KeyValuePair<string, object>>
in scopesScopes exported:
4. Duplicate Keys in scopes
Scopes exported:
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes