-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] LogExporter to serialize Exception Stack #672
[Exporter.Geneva] LogExporter to serialize Exception Stack #672
Conversation
Failed OpenTelemetry.Instrumentation.Wcf.Tests.TelemetryClientMessageInspectorTests.OutgoingRequestInstrumentationTest(instrument: True, filter: False, suppressDownstreamInstrumentation: True, includeVersion: False, enrich: False, enrichmentException: False, emptyOrNullAction: False) [1 ms] unrelated |
[xUnit.net 00:00:02.05] OpenTelemetry.Instrumentation.AspNet.Tests.HttpInMetricsListenerTests.HttpDurationMetricIsEmitted [FAIL] one more unrelated |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 77.55% 77.60% +0.05%
==========================================
Files 175 175
Lines 5310 5323 +13
==========================================
+ Hits 4118 4131 +13
Misses 1192 1192
|
Assert.Equal(typeof(MyException).FullName, actualExceptionType); | ||
|
||
var actualExceptionStack = exportedFields["env_ex_stack"]; | ||
Assert.EndsWith("...", (string)actualExceptionStack); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add another Assert
for exception stack length.
formatter: null); | ||
}, | ||
(genevaOptions) => | ||
genevaOptions.ExceptionStackExportOption = ExceptionStackExportOptions.ExportAsString); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could probably update this test to a Theory
to test both the exception stack export options.
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
src/OpenTelemetry.Exporter.Geneva/ExceptionStackExportOptions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for preview version.
Fixes #439
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes