[StackExchangeRedis] Fix benchmarks#4376
Merged
martincostello merged 3 commits intoMay 11, 2026
Merged
Conversation
Fix two benchmarks broken by open-telemetry#4095.
github-actions
Bot
added
perf
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes StackExchange.Redis benchmark projects that broke after #4095 changed how the Redis ActivitySource is exposed/identified (now using an ActivitySource instance created via ActivitySourceFactory).
Changes:
- Update benchmark
ActivityListener.ShouldListenTopredicates to compare againstStackExchangeRedisConnectionInstrumentation.ActivitySource.Nameinstead of the removedActivitySourceNameconstant. - Apply the same fix to both affected benchmark classes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/OpenTelemetry.Instrumentation.StackExchangeRedis.Benchmarks/RedisProfilerEntryToActivityConverterBenchmarks.cs | Fix listener source-name comparison to use ActivitySource.Name. |
| test/OpenTelemetry.Instrumentation.StackExchangeRedis.Benchmarks/RedisProfilerDrainSessionBenchmarks.cs | Fix listener source-name comparison to use ActivitySource.Name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add benchmarks to `.proj` file.
rajkumar-rangaraj
requested a deployment
to
external
GitHub Actions
Waiting
rajkumar-rangaraj
approved these changes
May 11, 2026
Merged
via the queue into
open-telemetry:main
with commit May 11, 2026
d08b817
913 of 918 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix two benchmarks broken by #4095.
This is also causing the daily job that publishes packages to MyGet to fail.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)