[AspNetCore] Update gRPC Semantic Conventions#4370
Draft
martincostello wants to merge 5 commits intoopen-telemetry:mainfrom
Draft
[AspNetCore] Update gRPC Semantic Conventions#4370martincostello wants to merge 5 commits intoopen-telemetry:mainfrom
martincostello wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
Add optimizations, recommended by Copilot, to reduce allocations in `HttpInListener.OnStopActivity()`: - Cache activity display names. - Uses slices instead of `Regex`. - Avoid enum reflection. - Null check delegates to avoid try-catch blocks. - Use SetCustomProperty to check for who made the instrumentation. - Avoid running gRPC-related code for HTTP 1.1. - Avoid additional check for the normalized HTTP method. - Use pattern matching on nullable.
Update the Semantic Conventions version for RPC Server spans to v1.41.0.
github-actions
Bot
added
the
comp:instrumentation.aspnetcore
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4370 +/- ##
==========================================
+ Coverage 75.62% 75.73% +0.11%
==========================================
Files 455 456 +1
Lines 18238 18313 +75
==========================================
+ Hits 13793 13870 +77
+ Misses 4445 4443 -2 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Also remove `grpc.status` and `grpc.target`.
martincostello
added
the
keep-open
Move RpcSemanticConventionHelper to shared code for re-use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #4090.
Changes
Update the Semantic Conventions version for gRPC Server spans to v1.41.0.
One thing I'm unsure of is whether or not we need to implement
OTEL_SEMCONV_STABILITY_OPT_INor not given that the support is already experimental.Once that question is answered I'll add/update the tests as appropriate.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)