Skip to content

[WCF] Add test for .NET Framework#4318

Merged
martincostello merged 1 commit into
open-telemetry:mainfrom
martincostello:gh-2584-2
Apr 28, 2026
Merged

[WCF] Add test for .NET Framework#4318
martincostello merged 1 commit into
open-telemetry:mainfrom
martincostello:gh-2584-2

Conversation

@martincostello
Copy link
Copy Markdown
Member

See #4026 (comment)

Changes

Add test missed from #4026.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@martincostello martincostello marked this pull request as ready for review April 28, 2026 14:35
Copilot AI review requested due to automatic review settings April 28, 2026 14:35
@martincostello martincostello requested a review from a team as a code owner April 28, 2026 14:35
@github-actions github-actions Bot added the comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.99%. Comparing base (3d15483) to head (3cc9ecd).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4318      +/-   ##
==========================================
- Coverage   75.99%   75.99%   -0.01%     
==========================================
  Files         466      466              
  Lines       18577    18577              
==========================================
- Hits        14118    14117       -1     
- Misses       4459     4460       +1     
Flag Coverage Δ
unittests-Instrumentation.Wcf 81.44% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a missing regression test in the WCF instrumentation test suite to cover the .NET Framework service-side dispatch path when an operation’s Action is null (related to the fix from #4026).

Changes:

  • Add a NETFRAMEWORK-only unit test that constructs an EndpointDispatcher with a DispatchOperation whose Action is null.
  • Assert the dispatch behavior path does not throw and registers a message inspector.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@martincostello martincostello added this pull request to the merge queue Apr 28, 2026
Merged via the queue into open-telemetry:main with commit faf02d9 Apr 28, 2026
70 checks passed
@martincostello martincostello deleted the gh-2584-2 branch April 28, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants