[Shared.SqlProcessor] Add support for handling unterminated escaped identifiers in sanitization#4317
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4317 +/- ##
==========================================
- Coverage 75.97% 75.87% -0.10%
==========================================
Files 466 466
Lines 18564 18572 +8
==========================================
- Hits 14104 14092 -12
- Misses 4460 4480 +20 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kielek
reviewed
Apr 28, 2026
Member
Kielek
left a comment
Kielek
left a comment
There was a problem hiding this comment.
I think that it deserve changelog entry.
SqlClient + EFCore as I rembmer/
format invariantly Changelogs
github-actions
Bot
added
comp:instrumentation.entityframeworkcore
ysolomchenko
force-pushed
the
Unclosed-escaped-identifiers-can-bypass-SQL-literal-sanitization
branch
from
7628da4 to
f0eb65d
Compare
martincostello
approved these changes
Apr 28, 2026
matt-hensley
approved these changes
Apr 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
open-telemetry:main
with commit Apr 29, 2026
052ddf2
316 of 317 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Design discussion issue # N/A
Found by Codex analysis
Changes
Add support for handling unterminated escaped identifiers in sanitization
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)