[Infra] Skip netfx reference assemblies on Windows#4287
Merged
martincostello merged 1 commit intoopen-telemetry:mainfrom Apr 30, 2026
Merged
[Infra] Skip netfx reference assemblies on Windows#4287martincostello merged 1 commit intoopen-telemetry:mainfrom
martincostello merged 1 commit intoopen-telemetry:mainfrom
Conversation
Only reference `Microsoft.NETFramework.ReferenceAssemblies` on non-Windows OS. Based on change in open-telemetry/opentelemetry-dotnet#7142.
github-actions
Bot
added
infra
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4287 +/- ##
==========================================
+ Coverage 73.87% 74.93% +1.06%
==========================================
Files 467 467
Lines 18435 18435
==========================================
+ Hits 13618 13815 +197
+ Misses 4817 4620 -197 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates central package management to avoid restoring Microsoft.NETFramework.ReferenceAssemblies on Windows, aligning reference-assembly usage with OS capabilities and reducing redundant package restore work.
Changes:
- Add an OS-based condition to only reference
Microsoft.NETFramework.ReferenceAssemblieson non-Windows. - Reorder attributes on global analyzer package references (no functional change intended).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kielek
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to open-telemetry/opentelemetry-dotnet#7142
Changes
Only reference
Microsoft.NETFramework.ReferenceAssemblieson non-Windows OS.I couldn't replicate the same failure here, but it makes sense to be consistent and skip restoring and referencing a redundant package on Windows.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)