[Resources.AWS] Ensure ECS cluster ARN is always in correct ARN format#4160
Merged
Conversation
github-actions
Bot
added
the
comp:resources.aws
ysolomchenko
marked this pull request as ready for review
April 20, 2026 13:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
==========================================
+ Coverage 73.83% 73.98% +0.14%
==========================================
Files 466 458 -8
Lines 18314 18279 -35
==========================================
Hits 13523 13523
+ Misses 4791 4756 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
|
||
| if (!clusterArn.StartsWith("arn:", StringComparison.Ordinal)) | ||
| { | ||
| var baseArn = containerArn.Substring(0, containerArn.LastIndexOf(':')); |
Member
There was a problem hiding this comment.
This doesn't validate that clusterArn contains a :.
martincostello
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Design discussion issue # N/A
Found by Codex analysis
Changes
Fix ECS Metadata V4 cluster ARN normalization when the
Clusterfield returns a cluster name instead of an ARN.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)