[Extensions] Use exception helper#4134
Merged
martincostello merged 2 commits intoApr 16, 2026
Merged
Conversation
Use `ArgumentOutOfRangeException.ThrowIfLessThanOrEqual` on .NET.
martincostello
marked this pull request as ready for review
April 16, 2026 12:20
martincostello
enabled auto-merge
April 16, 2026 12:20
Kielek
approved these changes
Apr 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
+ Coverage 72.77% 72.85% +0.07%
==========================================
Files 469 461 -8
Lines 18272 18206 -66
==========================================
- Hits 13298 13264 -34
+ Misses 4974 4942 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors RateLimitingSampler argument validation in OpenTelemetry.Extensions to use the built-in .NET exception helper API (ArgumentOutOfRangeException.ThrowIfLessThanOrEqual) when targeting modern .NET, while retaining the existing fallback for older TFMs.
Changes:
- Use
ArgumentOutOfRangeException.ThrowIfLessThanOrEqualunder#if NETformaxTracesPerSecondvalidation. - Keep the existing
if (...) throw ...path for non-NETtargets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ysolomchenko
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #4127.
Changes
Use
ArgumentOutOfRangeException.ThrowIfLessThanOrEqualon .NET.Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)