[OpAMP] Send custom messages#3809
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3809 +/- ##
=======================================
Coverage 72.01% 72.02%
=======================================
Files 447 447
Lines 17792 17834 +42
=======================================
+ Hits 12813 12845 +32
- Misses 4979 4989 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
stevejgordon
left a comment
There was a problem hiding this comment.
A few minor suggestions.
| } | ||
| } | ||
|
|
||
| [Event(EventIdFailedToSendCustomMessageMessage, Message = "Failed to send a custom messages: {0}", Level = EventLevel.Error)] |
There was a problem hiding this comment.
For consistency, should this message be: Failed to send a custom message message? This currently reads as if more than one custom message failed?
There was a problem hiding this comment.
The intent was Failed to send a custom message (without the typo). Failed to send a custom message message is definitely a more consistent way but just sounds weird. Any preferences here?
There was a problem hiding this comment.
I'm fine with Failed to send a custom message.
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Follow up to #3681
Changes
Enables agent to send custom messages.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes