Skip to content

[OpAMP] Send custom messages#3809

Merged
martincostello merged 6 commits intoopen-telemetry:mainfrom
RassK:opamp-send-custom-messages
Jan 27, 2026
Merged

[OpAMP] Send custom messages#3809
martincostello merged 6 commits intoopen-telemetry:mainfrom
RassK:opamp-send-custom-messages

Conversation

@RassK
Copy link
Copy Markdown
Contributor

@RassK RassK commented Jan 27, 2026

Follow up to #3681

Changes

Enables agent to send custom messages.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@RassK RassK requested a review from a team as a code owner January 27, 2026 11:55
@github-actions github-actions Bot added the comp:opamp.client Things related to OpenTelemetry.OpAmp.Client label Jan 27, 2026
@github-actions github-actions Bot requested a review from stevejgordon January 27, 2026 11:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.02%. Comparing base (41eb903) to head (3674e9e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ry.OpAmp.Client/Internal/OpAmpClientEventSource.cs 57.14% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3809   +/-   ##
=======================================
  Coverage   72.01%   72.02%           
=======================================
  Files         447      447           
  Lines       17792    17834   +42     
=======================================
+ Hits        12813    12845   +32     
- Misses       4979     4989   +10     
Flag Coverage Δ
unittests-OpAmp.Client 81.69% <85.71%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...penTelemetry.OpAmp.Client/Internal/FrameBuilder.cs 75.96% <100.00%> (+3.13%) ⬆️
...Telemetry.OpAmp.Client/Internal/FrameDispatcher.cs 94.02% <100.00%> (+1.57%) ⬆️
src/OpenTelemetry.OpAmp.Client/OpAmpClient.cs 88.88% <100.00%> (+0.42%) ⬆️
...ry.OpAmp.Client/Internal/OpAmpClientEventSource.cs 60.65% <57.14%> (-1.05%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions.

}
}

[Event(EventIdFailedToSendCustomMessageMessage, Message = "Failed to send a custom messages: {0}", Level = EventLevel.Error)]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, should this message be: Failed to send a custom message message? This currently reads as if more than one custom message failed?

Copy link
Copy Markdown
Contributor Author

@RassK RassK Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent was Failed to send a custom message (without the typo). Failed to send a custom message message is definitely a more consistent way but just sounds weird. Any preferences here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with Failed to send a custom message.

Comment thread src/OpenTelemetry.OpAmp.Client/OpAmpClient.cs Outdated
Comment thread src/OpenTelemetry.OpAmp.Client/OpAmpClient.cs Outdated
Comment thread src/OpenTelemetry.OpAmp.Client/OpAmpClient.cs Outdated
RassK and others added 3 commits January 27, 2026 15:49
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
@martincostello martincostello added this pull request to the merge queue Jan 27, 2026
Merged via the queue into open-telemetry:main with commit 4b696ae Jan 27, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:opamp.client Things related to OpenTelemetry.OpAmp.Client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants