[Infra] GetTargetFrameworkIdentifier for baselines #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make TFM-specific public API baselines not use the specific TFM version. See open-telemetry#3079 (comment).
martincostello
had a problem deploying
to
external
GitHub Actions
Failure
4 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the public API baseline configuration to use target framework identifiers instead of specific target framework monikers (TFMs). This allows for more flexible TFM-specific public API baselines that don't tie to specific framework versions.
- Adds MSBuild function call to extract framework identifier from target framework
- Enables framework-specific API baselines without version-specific constraints
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
infra
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3083 +/- ##
==========================================
- Coverage 69.81% 69.61% -0.20%
==========================================
Files 410 420 +10
Lines 16266 16315 +49
==========================================
+ Hits 11356 11358 +2
- Misses 4910 4957 +47 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Kielek
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3079 (comment).
Changes
Make TFM-specific public API baselines not use the specific TFM version.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)