-
Notifications
You must be signed in to change notification settings - Fork 355
[EFCore] [SqlClient] Remove SetDbQueryParameters #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make the new `SetDbQueryParameters` property internal and gate behind an environment variable instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the SetDbQueryParameters property internal and configures it through environment variables instead of exposing it as a public API. The change affects both SqlClient and EntityFrameworkCore instrumentation libraries.
Key changes:
- Made
SetDbQueryParametersproperty internal instead of public - Added environment variable configuration for both libraries
- Updated documentation to remove public API usage examples
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SqlClientTraceInstrumentationOptions.cs | Made SetDbQueryParameters internal and added environment variable configuration |
| EntityFrameworkInstrumentationOptions.cs | Made SetDbQueryParameters internal and added environment variable configuration |
| SqlClient README.md | Removed public API documentation section |
| EntityFrameworkCore README.md | Removed public API documentation section |
| Test files | Added tests for environment variable configuration |
| PublicAPI.Unshipped.txt | Removed public API entries |
| CHANGELOG.md | Updated to reference environment variable instead of public option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/EntityFrameworkInstrumentationOptions.cs
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
==========================================
+ Coverage 69.74% 69.87% +0.12%
==========================================
Files 410 410
Lines 16264 16239 -25
==========================================
+ Hits 11344 11347 +3
+ Misses 4920 4892 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Add link to this PR too. Co-authored-by: Piotr Kiełkowicz <[email protected]>
Restore the original README content for `SetDbQueryParameters` under a new Experimental features heading.
Be consistent with the other notes.
Fixes #3078
Changes
Make the new
SetDbQueryParametersproperty internal and gate behind an environment variable instead.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes