[Infra] Add EnabledOnDockerPlatformFact #3028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:instrumentation.entityframeworkcore
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Docker platform detection logic by extracting common functionality into reusable helper classes and creating a new [EnabledOnDockerPlatformFact] attribute alongside the existing [EnabledOnDockerPlatformTheory] attribute.
- Extract Docker detection logic into a shared
DockerHelperclass - Create new
EnabledOnDockerPlatformFactAttributefor single test scenarios - Move
DockerPlatformenum to a separate file for better organization
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Shared/EnabledOnDockerPlatformTheoryAttribute.cs | Refactored to use the new DockerHelper instead of inline Docker detection logic |
| test/Shared/EnabledOnDockerPlatformFactAttribute.cs | New attribute for Fact tests that need Docker platform validation |
| test/Shared/DockerPlatform.cs | Extracted enum to separate file for better code organization |
| test/Shared/DockerHelper.cs | New helper class containing the Docker platform detection logic |
| test/OpenTelemetry.Instrumentation.SqlClient.Tests/SqlClientIntegrationTests.cs | Updated attribute reference and simplified assertion |
| test/OpenTelemetry.Instrumentation.SqlClient.Tests/OpenTelemetry.Instrumentation.SqlClient.Tests.csproj | Added references to new shared files |
| test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests.csproj | Added references to new shared files |
| test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkIntegrationTests.cs | Updated attribute reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
- Coverage 69.61% 69.60% -0.02%
==========================================
Files 413 413
Lines 16203 16207 +4
==========================================
+ Hits 11280 11281 +1
- Misses 4923 4926 +3 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Split out the implementation in `[EnabledOnDockerPlatformTheory]` to allow for a `[EnabledOnDockerPlatformFact]`.
martincostello
force-pushed
the
add-EnabledOnDockerPlatformFact
branch
from
4b4eb71 to
4902e78
Compare
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Split out the implementation in
[EnabledOnDockerPlatformTheory]to allow for a[EnabledOnDockerPlatformFact].Cherry-picked from #3015.
Merge requirement checklist
AppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)