-
Notifications
You must be signed in to change notification settings - Fork 357
[Resources.ProcessRuntime] Allow preview versions #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the test assertion for ProcessRuntime attributes to support preview and release candidate .NET versions.
- Updated the regex in ProcessRuntimeDetectorTests.cs to correctly match preview and RC versions.
- Ensured compatibility with the test for .NET version string formatting.
test/OpenTelemetry.Resources.ProcessRuntime.Tests/ProcessRuntimeDetectorTests.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
==========================================
+ Coverage 73.91% 83.33% +9.41%
==========================================
Files 267 4 -263
Lines 9615 60 -9555
==========================================
- Hits 7107 50 -7057
+ Misses 2508 10 -2498
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
0482831 to
aa00620
Compare
aa00620 to
42b226e
Compare
Update assertion to not fail if a preview or release candidate version of .NET is being used.
42b226e to
10fb717
Compare
|
@martincostello, thank you. Merging. |
Changes
Update assertion to not fail if a preview or release candidate version of .NET is being used.
See #2822.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes