Skip to content

Add db.operation.name attribute#2800

Merged
alanwest merged 3 commits intoopen-telemetry:mainfrom
alanwest:alanwest/sql-operation-name
May 22, 2025
Merged

Add db.operation.name attribute#2800
alanwest merged 3 commits intoopen-telemetry:mainfrom
alanwest:alanwest/sql-operation-name

Conversation

@alanwest
Copy link
Copy Markdown
Member

I originally removed the db.operation.name attribute in #2693, but forgot to add it back after the final result of this discussion #2693 (comment).

@alanwest alanwest requested a review from a team as a code owner May 20, 2025 22:43
@github-actions github-actions Bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label May 20, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (71655ce) to head (b016054).
Report is 862 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2800       +/-   ##
===========================================
+ Coverage   73.91%   87.97%   +14.05%     
===========================================
  Files         267        9      -258     
  Lines        9615      449     -9166     
===========================================
- Hits         7107      395     -6712     
+ Misses       2508       54     -2454     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 87.97% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...qlClient/Implementation/SqlActivitySourceHelper.cs 90.90% <100.00%> (ø)
...ient/Implementation/SqlClientDiagnosticListener.cs 86.61% <100.00%> (ø)

... and 268 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alanwest alanwest merged commit 03c5779 into open-telemetry:main May 22, 2025
61 checks passed
@alanwest alanwest deleted the alanwest/sql-operation-name branch May 22, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants