[Instrumentation.StackExchangeRedis] Adopt v1.23 database span network attributes #2468
+46
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-hensley
had a problem deploying
to
external
GitHub Actions
Failure
github-actions
bot
added
the
comp:instrumentation.stackexchangeredis
matt-hensley
had a problem deploying
to
external
GitHub Actions
Failure
matt-hensley
had a problem deploying
to
external
GitHub Actions
Failure
# Conflicts: # src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md
matt-hensley
had a problem deploying
to
external
GitHub Actions
Failure
Kielek
reviewed
Jan 20, 2025
Member
Kielek
left a comment
Kielek
left a comment
There was a problem hiding this comment.
LGTM, only changelog formating.
Kielek
approved these changes
Jan 20, 2025
matt-hensley
had a problem deploying
to
external
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
==========================================
- Coverage 73.91% 0 -73.92%
==========================================
Files 267 0 -267
Lines 9615 0 -9615
==========================================
- Hits 7107 0 -7107
+ Misses 2508 0 -2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adopt v1.23 database span network attributes. This does not update any other attributes that may be out of date.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes