Skip to content

Conversation

@ppittle
Copy link
Member

@ppittle ppittle commented Dec 20, 2024

Fixes #
Design discussion issue # Continuation of #2367

Changes

Update the OpenTelemetry.*.AWS libraries to to use Semantic Convention 1.28 and remove the option SemanticConventionVerisons.Legacy

Background

We determined that #2367, should not change Semantic Conventions by default, allowing users a non-breaking way to test opting in-to 1.28.

This is a fast follow up PR that removes SemanticConventionVersions.Legacy and changes the default to SemanticConventionVersions.V1_28_0. This PR is to be released as a Release Candidate.

This follows the release strategy for other contrib packages that have made similar breaking changes around Semantic Convention stabilization.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ppittle ppittle requested a review from a team as a code owner December 20, 2024 01:00
@github-actions github-actions bot added comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda comp:resources.aws Things related to OpenTelemetry.Resources.AWS labels Dec 20, 2024
@ppittle
Copy link
Member Author

ppittle commented Dec 20, 2024

@Oberon00 - this PR come out of a discussion you and @alanwest and I were having in #2367.

Would you mind reviewing?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 30, 2024
@ppittle ppittle force-pushed the default-to-1.28-sem-conv branch from 1c5cffd to 311410a Compare January 3, 2025 18:58
@alanwest alanwest merged commit 66eedd7 into open-telemetry:main Jan 6, 2025
217 checks passed
@codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (71655ce) to head (311410a).
Report is 674 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2437       +/-   ##
==========================================
- Coverage   73.91%       0   -73.92%     
==========================================
  Files         267       0      -267     
  Lines        9615       0     -9615     
==========================================
- Hits         7107       0     -7107     
+ Misses       2508       0     -2508     

see 263 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda comp:resources.aws Things related to OpenTelemetry.Resources.AWS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants