Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Add exponential histogram support for otlp protobuf format #1705

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented May 6, 2024

Fixes #1378

Changes

Adds support for exporting exponential histograms when OTLP protobuf encoding is enable for metric exporter.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.22%. Comparing base (71655ce) to head (e603c0b).
Report is 233 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
- Coverage   73.91%   64.22%   -9.69%     
==========================================
  Files         267       35     -232     
  Lines        9615     3567    -6048     
==========================================
- Hits         7107     2291    -4816     
+ Misses       2508     1276    -1232     
Flag Coverage Δ
unittests-Exporter.Geneva 64.22% <92.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eneva/Metrics/OtlpProtobuf/FieldNumberConstants.cs 80.00% <ø> (ø)
...a/Metrics/OtlpProtobuf/ProtobufSerializerHelper.cs 100.00% <100.00%> (ø)
...eva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs 90.65% <91.66%> (ø)

... and 249 files with indirect coverage changes

@Kielek Kielek added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label May 6, 2024
@vishweshbankwar vishweshbankwar changed the title [Exporter.Geneva] Add exponential histogram support [Exporter.Geneva] Add exponential histogram support for otlp protobuf format May 6, 2024
@vishweshbankwar vishweshbankwar marked this pull request as ready for review May 7, 2024 22:30
@vishweshbankwar vishweshbankwar requested a review from a team May 7, 2024 22:30
@vishweshbankwar vishweshbankwar merged commit 2d8a0ca into open-telemetry:main May 13, 2024
38 checks passed
@vishweshbankwar
Copy link
Member Author

Received approval from component owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter.Geneva support for exponential histograms
7 participants