-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Add exponential histogram support for otlp protobuf format #1705
Merged
vishweshbankwar
merged 16 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/add-exponential-histogram-support
May 13, 2024
Merged
[Exporter.Geneva] Add exponential histogram support for otlp protobuf format #1705
vishweshbankwar
merged 16 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/add-exponential-histogram-support
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
- Coverage 73.91% 64.22% -9.69%
==========================================
Files 267 35 -232
Lines 9615 3567 -6048
==========================================
- Hits 7107 2291 -4816
+ Misses 2508 1276 -1232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…github.com/vishweshbankwar/opentelemetry-dotnet-contrib into vibankwa/add-exponential-histogram-support
utpilla
reviewed
May 8, 2024
src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs
Show resolved
Hide resolved
utpilla
reviewed
May 8, 2024
test/OpenTelemetry.Exporter.Geneva.Tests/OtlpProtobufMetricExporterTests.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
May 8, 2024
test/OpenTelemetry.Exporter.Geneva.Tests/OtlpProtobufMetricExporterTests.cs
Show resolved
Hide resolved
utpilla
reviewed
May 8, 2024
test/OpenTelemetry.Exporter.Geneva.Tests/OtlpProtobufMetricExporterTests.cs
Outdated
Show resolved
Hide resolved
…github.com/vishweshbankwar/opentelemetry-dotnet-contrib into vibankwa/add-exponential-histogram-support
…github.com/vishweshbankwar/opentelemetry-dotnet-contrib into vibankwa/add-exponential-histogram-support
utpilla
approved these changes
May 13, 2024
Received approval from component owner. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378
Changes
Adds support for exporting exponential histograms when OTLP protobuf encoding is enable for metric exporter.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes